This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-556. [WEB] Connect workbench with database for metric #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pingsutw @liuxunorg Please help me review this pr, thanks a lot. |
pingsutw
reviewed
Jul 19, 2020
| <th>Value</th> | ||
| <th>Time</th> | ||
| <th>Step</th> | ||
| <th>Is_NaN</th> |
There was a problem hiding this comment.
We could remove this line
If Is_NaN is true, we set metric value string to "Nan"
xunliu
reviewed
Jul 20, 2020
There was a problem hiding this comment.
@kobe860219 You forgot convert the PR title to uppercase. SUBMARINE-556. xxx
Remember next time.
kobe860219
changed the title
xunliu
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
@kobe860219 Thank you contrirbution this feature.
Will merge if no more comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Connect workbench with database for metric.
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-556
How should this be tested?
https://travis-ci.org/github/kobe860219/submarine/builds/709419937
Screenshots (if appropriate)
Questions: