Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-568. [WEB] Fix a display bug in experiment info page #355

Closed
wants to merge 2 commits into from

Conversation

kobe860219
Copy link
Contributor

What is this PR for?

  • Fix problem that when reload experiment info page, the experimentID in breadcrumb will miss.
  • Adjustment the presenting of experiment info output page to be more friendly for users.

What type of PR is it?

[Feature]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-568

How should this be tested?

https://travis-ci.org/github/kobe860219/submarine/builds/711355007

Screenshots (if appropriate)

螢幕錄製 2020-07-24 下午1

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@kobe860219
Copy link
Contributor Author

@pingsutw Please help me review this pr, thanks :)

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kobe860219
Overall LGTM.
A nit in a comment.

@kobe860219 kobe860219 requested a review from pingsutw July 24, 2020 14:57
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @kobe860219

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Will merge if no more comments.

@asfgit asfgit closed this in 6ee7105 Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants