Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-575. [SDK] Set job_name to id in database #356

Closed
wants to merge 8 commits into from

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jul 24, 2020

What is this PR for?

In the submarine server, we set experiment_1595332719154_0001 as id in the MySQL table.
We should also update the logging module in SDK

update include:

  • Remove job_name in MySQL table, and set experiment_1595332719154_0001 to id
  • Automatically set worker_index when using submarine.log_metirc or submarine.log_param

What type of PR is it?

[Refactoring]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-575

How should this be tested?

https://travis-ci.org/github/pingsutw/hadoop-submarine/builds/711362155

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@pingsutw pingsutw force-pushed the SUBMARINE-575 branch 2 times, most recently from 7a45167 to 8989af3 Compare July 24, 2020 08:22
Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 4f685c0 Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants