Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-576. Always return empty list when listing environments #358

Closed
wants to merge 5 commits into from

Conversation

manirajv06
Copy link
Contributor

What is this PR for?

https://issues.apache.org/jira/browse/SUBMARINE-576

What type of PR is it?

Feature

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-576

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? Yes/No
  • Is there breaking changes for older versions? Yes/No
  • Does this needs documentation? Yes/No

@manirajv06
Copy link
Contributor Author

@pingsutw Can you please review? Environment spec 'name' is not allowed for updates, hence modified corresponding test case as well. In addition, committed few more changes to #348 as well to reflect the same.

@manirajv06 manirajv06 changed the title [SUBMARINE-576] Always return empty list when listing environments SUBMARINE-576. Always return empty list when listing environments Jul 25, 2020
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manirajv06 Thanks for the contribution.
It looks good to me.
if I understand correctly, we store environment data in the cache currently.
Will we support to store data in DB in other JIRA ticket?

@manirajv06
Copy link
Contributor Author

@pingsutw Data has been already stored in database (in "environment" table). In-memory cache support has been added mainly from performance perspective to save the db calls. Can you please commit the code as @lowc1012 might be expecting this change?

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @manirajv06 Thank you contribution this feature.
Will merge if no more comments.

@asfgit asfgit closed this in 5d5eec3 Jul 29, 2020
@manirajv06
Copy link
Contributor Author

manirajv06 commented Jul 30, 2020

@liuxunorg PR #348 commits also has been merged into the master. We will need to remove those commits . Only this commit e7476c7 should have gone into the master. Can you please check? Am not sure whether this confusion would have started with the way I made commits from my local copy into my github fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants