-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUBMARINE-576. Always return empty list when listing environments #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manirajv06 Thanks for the contribution.
It looks good to me.
if I understand correctly, we store environment data in the cache currently.
Will we support to store data in DB in other JIRA ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @manirajv06 Thank you contribution this feature.
Will merge if no more comments.
@liuxunorg PR #348 commits also has been merged into the master. We will need to remove those commits . Only this commit e7476c7 should have gone into the master. Can you please check? Am not sure whether this confusion would have started with the way I made commits from my local copy into my github fork. |
What is this PR for?
https://issues.apache.org/jira/browse/SUBMARINE-576
What type of PR is it?
Feature
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-576
How should this be tested?
Screenshots (if appropriate)
Questions: