Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-588. [SDK] Fix checkstyle error in core.py #365

Closed
wants to merge 4 commits into from

Conversation

pingsutw
Copy link
Member

What is this PR for?

Fix checkstyle error in submarine/ml/pytorch/model/ctr/
https://github.com/apache/submarine/runs/923503735

Run ./submarine-sdk/pysubmarine/github-actions/lint.sh
+++ dirname ./submarine-sdk/pysubmarine/github-actions/lint.sh
++ cd ./submarine-sdk/pysubmarine/github-actions
++ pwd
+ FWDIR=/home/runner/work/submarine/submarine/submarine-sdk/pysubmarine/github-actions
+ cd /home/runner/work/submarine/submarine/submarine-sdk/pysubmarine/github-actions
+ cd ..
+ pycodestyle --max-line-length=100 -- submarine tests
+ pylint --ignore experiment '--msg-template={path} ({line},{column}): [{msg_id} {symbol}] {msg}' --rcfile=pylintrc -- submarine tests
************* Module submarine.ml.pytorch.model.ctr.afm
submarine/ml/pytorch/model/ctr/afm.py (30,0): [W0223 abstract-method] Method '_forward_unimplemented' is abstract in class 'Module' but is not overridden
submarine/ml/pytorch/model/ctr/afm.py (57,0): [W0223 abstract-method] Method '_forward_unimplemented' is abstract in class 'Module' but is not overridden
submarine/ml/pytorch/model/ctr/afm.py (81,0): [W0223 abstract-method] Method '_forward_unimplemented' is abstract in class 'Module' but is not overridden
************* Module submarine.ml.pytorch.model.ctr.deepfm
submarine/ml/pytorch/model/ctr/deepfm.py (32,0): [W0223 abstract-method] Method '_forward_unimplemented' is abstract in class 'Module' but is not overridden
************* Module submarine.ml.pytorch.layers.core
submarine/ml/pytorch/layers/core.py (20,0): [W0223 abstract-method] Method '_forward_unimplemented' is abstract in class 'Module' but is not overridden
submarine/ml/pytorch/layers/core.py (42,0): [W0223 abstract-method] Method '_forward_unimplemented' is abstract in class 'Module' but is not overridden
submarine/ml/pytorch/layers/core.py (57,0): [W0223 abstract-method] Method '_forward_unimplemented' is abstract in class 'Module' but is not overridden
submarine/ml/pytorch/layers/core.py (72,0): [W0223 abstract-method] Method '_forward_unimplemented' is abstract in class 'Module' but is not overridden

What type of PR is it?

[Hot Fix]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-588

How should this be tested?

https://travis-ci.org/github/pingsutw/hadoop-submarine/builds/712952549

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 8260a08 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants