This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-585. [WEB] Edit existing experiments through UI #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wang0630
force-pushed
the
SUBMARINE-585
branch
2 times, most recently
from
e344901
to
ae7786c
Compare
pingsutw
reviewed
Aug 3, 2020
|
I suggest that we could change "Edit" to "Update" |
pingsutw
reviewed
Aug 3, 2020
There was a problem hiding this comment.
Thanks @wang0630 for the contribution.
@liuxunorg @kobe860219 @kevin85421 Could you also take a look at it, thanks.
| @@ -69,8 +69,9 @@ public void experimentNavigation() throws Exception { | |||
|
|
|||
| // Test create new experiment | |||
| LOG.info("new experiment"); | |||
| String experimentName = "good-e2e-testt"; | |||
There was a problem hiding this comment.
Suggested change
| String experimentName = "good-e2e-testt"; | |
| String experimentName = "experiment-e2e-test"; |
submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/experimentIT.java
Show resolved
Hide resolved
Now users can edit experiments through UI, except experiment names. In addition, improving the UI in experiment page for clarity.
|
Will merge if no more comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Allow editing experiments through UI.
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
SUBMARINE-585
How should this be tested?
https://travis-ci.com/github/wang0630/submarine/builds/178169720
Screenshots (if appropriate)
Questions: