Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-592. ExperimentRestApiIT#testTensorFlowUsingEnvWithJsonSpec assert fixes #370

Closed
wants to merge 1 commit into from

Conversation

manirajv06
Copy link
Contributor

What is this PR for?

https://issues.apache.org/jira/browse/SUBMARINE-592

What type of PR is it?

Bug Fix

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-592

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? Yes/No
  • Is there breaking changes for older versions? Yes/No
  • Does this needs documentation? Yes/No

@manirajv06
Copy link
Contributor Author

manirajv06 commented Aug 3, 2020

@pingsutw Can you please take a look?
Also, a general question of Git PR work flow - This PR should contain only b9c5475, but it is showing up other PR commits which is not yet reviewed and committed by Reviewers. In this case, Should I need to squash those un necessary commits before committing the code for this PR or Would reviewers take care of this?

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @manirajv06, b9c5475 looks good to me

Also, a general question of Git PR work flow - This PR should contain only b9c5475, but it is showing up other PR commits which is not yet reviewed and committed by Reviewers. In this case, Should I need to squash those un necessary commits before committing the code for this PR or Would reviewers take care of this?

The PR should only contain the commit related to this Jira, or other commits will also be merged.
After dropping out the other commits and force push again, we could merge this PR.

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manirajv06 Thank you contribution.
The title of this PR is too long, please shorten it.

@manirajv06 manirajv06 changed the title SUBMARINE-592. ExperimentRestApiIT#testTensorFlowUsingEnvWithJsonSpec doesn't do expected asserts SUBMARINE-592. ExperimentRestApiIT#testTensorFlowUsingEnvWithJsonSpec assert fixes Aug 5, 2020
@manirajv06
Copy link
Contributor Author

The PR should only contain the commit related to this Jira, or other commits will also be merged.
After dropping out the other commits and force push again, we could merge this PR.

done

@manirajv06
Copy link
Contributor Author

@manirajv06 Thank you contribution.
The title of this PR is too long, please shorten it.

done

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Copy link
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @manirajv06 for your contribution. Thanks @liuxunorg and @pingsutw help to review. I'll commit it after the Checks done.

@asfgit asfgit closed this in 66754b0 Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants