-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUBMARINE-592. ExperimentRestApiIT#testTensorFlowUsingEnvWithJsonSpec assert fixes #370
Conversation
@pingsutw Can you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manirajv06, b9c5475 looks good to me
Also, a general question of Git PR work flow - This PR should contain only b9c5475, but it is showing up other PR commits which is not yet reviewed and committed by Reviewers. In this case, Should I need to squash those un necessary commits before committing the code for this PR or Would reviewers take care of this?
The PR should only contain the commit related to this Jira, or other commits will also be merged.
After dropping out the other commits and force push again, we could merge this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manirajv06 Thank you contribution.
The title of this PR is too long, please shorten it.
…onSpec doesn't do expected asserts
b9c5475
to
c205978
Compare
done |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Thanks @manirajv06 for your contribution. Thanks @liuxunorg and @pingsutw help to review. I'll commit it after the Checks done.
What is this PR for?
https://issues.apache.org/jira/browse/SUBMARINE-592
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-592
How should this be tested?
Screenshots (if appropriate)
Questions: