This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-584. Add unit test for ExperimentRestApi.java #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @aeioulisa for the work. Could you please change the title of the PR ? |
aeioulisa
changed the title
aeioulisa
changed the title
xunliu
reviewed
Aug 12, 2020
pingsutw
reviewed
Aug 12, 2020
There was a problem hiding this comment.
Thanks @aeioulisa for the contribution.
some comments in the below.
...server/server-core/src/test/java/org/apache/submarine/server/rest/ExperimentRestApiTest.java
Outdated
Show resolved
Hide resolved
...server/server-core/src/test/java/org/apache/submarine/server/rest/ExperimentRestApiTest.java
Outdated
Show resolved
Hide resolved
...server/server-core/src/test/java/org/apache/submarine/server/rest/ExperimentRestApiTest.java
Outdated
Show resolved
Hide resolved
...server/server-core/src/test/java/org/apache/submarine/server/rest/ExperimentRestApiTest.java
Outdated
Show resolved
Hide resolved
jiwq
reviewed
Aug 13, 2020
...ine-server/server-core/src/main/java/org/apache/submarine/server/rest/ExperimentRestApi.java
Show resolved
Hide resolved
...server/server-core/src/test/java/org/apache/submarine/server/rest/ExperimentRestApiTest.java
Show resolved
Hide resolved
...server/server-core/src/test/java/org/apache/submarine/server/rest/ExperimentRestApiTest.java
Outdated
Show resolved
Hide resolved
|
+1, I recommend renaming the |
|
Thanks @aeioulisa update the last commit. Thanks @cxorm @liuxunorg and @pingsutw help to review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add unit test for ExperimentRestApi.java
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-584
How should this be tested?
https://travis-ci.org/github/apache/submarine/jobs/717575609
Screenshots (if appropriate)
Questions: