Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-608. [WEB] Create environment through UI #402

Closed
wants to merge 2 commits into from

Conversation

kobe860219
Copy link
Contributor

What is this PR for?

Complete creation environment through UI.

What type of PR is it?

[Feature]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-608

How should this be tested?

https://travis-ci.org/github/kobe860219/submarine/builds/727321947

Screenshots (if appropriate)

螢幕錄製 2020-09-15 下午4

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@kobe860219
Copy link
Contributor Author

@pingsutw @xunliu @jiwq Please help me review this pr. Thanks !

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kobe860219 for the contribution

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Will commit if no more comments.

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 329fec8 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants