Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-618. Create/Delete IngressRoute with Notebook CR #404

Closed
wants to merge 1 commit into from

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Sep 16, 2020

What is this PR for?

Traefik uses CRD (IngressRoute) to retrieve its routing configuration.
In order to route the traffic to jupyter notebooks, we should add routing rules by creating a IngressRoute witch pair with notebook's service.

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

SUBMARINE-618

How should this be tested?

Travis CI

Screenshots (if appropriate)

img1
img2
img3

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lowc1012
Just try this PR, it works well for me

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lowc1012 Thank you for complated this important feature!
LGTM

Copy link
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lowc1012 for the work and @pingsutw @xunliu for the review.
+1 Commit to trunk.

@asfgit asfgit closed this in 3d19524 Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants