SUBMARINE-623. Experiment templates cannot use pure digital parameters #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTing
force-pushed
the
SUBMARINE-623
branch
from
6052e23
to
2200a09
Compare
pingsutw
reviewed
Oct 27, 2020
.../src/main/java/org/apache/submarine/server/experimenttemplate/ExperimentTemplateManager.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/apache/submarine/server/experimenttemplate/ExperimentTemplateManager.java
Show resolved
Hide resolved
.../src/main/java/org/apache/submarine/server/experimenttemplate/ExperimentTemplateManager.java
Outdated
Show resolved
Hide resolved
JohnTing
force-pushed
the
SUBMARINE-623
branch
from
603f45a
to
b18aba5
Compare
rebase squash change change change change test2 change1 change2 change3 change4 change4 database text1 doc doc doc Update submarine-server/server-core/src/main/java/org/apache/submarine/server/experimenttemplate/ExperimentTemplateManager.java Co-authored-by: HUAN-PING SU <pingsutw@gmail.com> Update docs/database/submarine-data.sql Co-authored-by: HUAN-PING SU <pingsutw@gmail.com> Update docs/userdocs/k8s/api/experiment-template.md Co-authored-by: HUAN-PING SU <pingsutw@gmail.com> Update submarine-server/server-core/src/main/java/org/apache/submarine/server/experimenttemplate/ExperimentTemplateManager.java Co-authored-by: HUAN-PING SU <pingsutw@gmail.com> change to apache image Resolve conflicts Resolve conflicts Resolve conflicts
JohnTing
force-pushed
the
SUBMARINE-623
branch
from
121dc84
to
a499fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Now experiment templates cannot use pure digital parameters,
For example,
if the following "replicas", using
"{{Master.replicas}}", the experiment will fail.If the "replicas" uses
{{Master.replicas}}, it will not be parsed as json.
"spec": {
"Master": {
"replicas": 1,
"resources": "cpu=1,memory=1024M"
},
"Worker": {
"replicas": 1,
"resources": "cpu=1,memory=1024M"
}
}
This PR adds another way to map parameters
It will replace the parameter according to the json path.
{ "name": "spec.Master.replicas", "value": 1, "required": true, "description": "Ps replicas." }What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-623
How should this be tested?
Screenshots (if appropriate)
Questions: