This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-643. Make git-sync image configurable #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pingsutw Thanks for the patch! LGTM. We can merge this PR. But it doesn't make it configurable now. So let's change the JIRA title to "Use git-sync image from Docker hub" . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
For the known reason, this gcr image cannot be pulled from some places. We should make this configurable in helm charts and pass this to the submarine server by an environment variable.
In the other hand, we pushed this image to the Apache Docker hub with the name "apache/submarine:git-sync-3.1.6" as a default image.
public static final String GIT_SYNC_IMAGE = "k8s.gcr.io/git-sync:v3.1.6";What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-643
How should this be tested?
https://travis-ci.org/github/pingsutw/hadoop-submarine/builds/731185896
Screenshots (if appropriate)
Questions: