Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-648. Add a submarine-sdk example in Jupyter notebook #427

Closed
wants to merge 3 commits into from

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Oct 5, 2020

What is this PR for?

To enhance the user experience of notebook, we could add a submarine sdk example under the working directory (default is "/home/jovyan/") in jupyter notebook.

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

SUBMARINE-648

How should this be tested?

travis CI

Screenshots (if appropriate)

img

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lowc1012
Other LGTM

Co-authored-by: HUAN-PING SU <pingsutw@gmail.com>
Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 5f63b7e Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants