Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-636. Update user documents for notebook #431

Closed
wants to merge 3 commits into from
Closed

SUBMARINE-636. Update user documents for notebook #431

wants to merge 3 commits into from

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Oct 6, 2020

What is this PR for?

Update "docs/userdocs/k8s/notebook.md" and "docs/userdocs/k8s/api/notebook.md"

What type of PR is it?

[Documentation]

Todos

  • - Task

What is the Jira issue?

SUBMARINE-636

How should this be tested?

Travis CI

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

pingsutw
pingsutw approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @lowc1012
I think the new doc is very clear for users

jiwq
jiwq approved these changes Oct 10, 2020
View reviewed changes
Copy link
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Will commit if no more comments.

@asfgit asfgit closed this in f896803 Oct 11, 2020
@jojochuang jojochuang mentioned this pull request Apr 25, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Apr 25, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jiwq jiwq jiwq approved these changes

@pingsutw pingsutw pingsutw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lowc1012 @jiwq @pingsutw