SUBMARINE-676. Add NG-ZORRO UI component library to notebook page #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kobe860219 |
|
@kobe860219 Please help to resolve the conflicts. Thanks! |
kobe860219
force-pushed
the
SUBMARINE-676
branch
from
5f1d766
to
8befc57
Compare
|
@lowc1012 I have resolved conflicts :) |
|
Will merge this pr if no more comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
We use NG-ZORRO as the UI Component library in Workbench Web. But the form in notebook page of WEB has not been used yet. We should make the WEB interface all use uniformly.
What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-676
How should this be tested?
https://travis-ci.org/github/kobe860219/submarine/builds/744476551
Screenshots (if appropriate)
Questions: