Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-692. [web] Replace hand-crafted authguard with Angular builtin function #469

Closed
wants to merge 1 commit into from

Conversation

ByronHsu
Copy link
Member

@ByronHsu ByronHsu commented Dec 3, 2020

What is this PR for?

  1. Replace hand-crafted authguard with Angular builtin function
  2. Remove notebook route module. Because there is only one path there, we don't need to use routing module

What type of PR is it?

[mprovement]

What is the Jira issue?

https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-692

How should this be tested?

https://github.com/ByronHsu/submarine/actions/runs/398816623

Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @ByronHsu

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 6ec50ec Dec 8, 2020
@ByronHsu ByronHsu deleted the SUBMARINE-692 branch May 3, 2021 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants