-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUBMARINE-942. Make experiment ID consistent with TFJob and PyTorch Job #683
Conversation
@pingsutw and I are trying to figure out the root cause of a weird problem about test-k8s. Hence, this PR is not ready to be reviewed. Thanks! Update: the root cause of the weird problem is written in the "What is this PR for?". |
@pingsutw I have removed the field |
Reopen it since some tests failed. |
@pingsutw In my opinion, the root cause of the CI error is caused by SUBMARINE-946 rather than SUBMARINE-942. The error message indicates that the package does not be loaded into the maven repo. If needed, I can try to fix the error. |
But tests passed after I revert SUBMARINE-942. |
@pingsutw This is because other pull requests do not change the submarine-server-core module. I will rebase the merged commits to reproduce the CI failures. |
594e46f
to
51cb410
Compare
What is this PR for?
Please refer to the following two JIRA issues.
In this JIRA issue, we need to make the experiment ID consistent with the name of TFJob and PyTorch Job. The difference is caused by this link. Update ExperimentId.java.
Update IntegrationTestK8s.md
mvn clean package -DskipTests
. However, the package will be installed into the local repository at install phase, a later phase than both package and verify phases.mvn install -DskipTests
to ensure that the test-k8s module uses the latest "submarine-server-core" module.Remove the field
name
in Experiment.java because the value ofname
is the same asexperimentId
.What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-942
How should this be tested?
Screenshots (if appropriate)
Questions: