Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-922. Migrate to the next version of Python requests when released #722

Closed
wants to merge 1 commit into from

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Aug 26, 2021

What is this PR for?

Install latest request in the pysubmarine.

See Github issue: #661

Our python code uses requests library which has transitive dependency on a GPL lib chardet.

We're not supposed to make an ASF release knowing there's a GPL transitive dependency so this is a blocker for our 0.6.0 release.

Quickly checked the code, we have two places that use the library. We could wait for the new requests or perhaps remove the usage.

find . -name "*.py" | xargs grep "import requests"
./submarine-sdk/pysubmarine/submarine/utils/rest_utils.py:import requests
./submarine-sdk/pysubmarine/build/lib/submarine/utils/rest_utils.py:import requests

What type of PR is it?

[Hot Fix]

Todos

No

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-922

How should this be tested?

Pass the CIs

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant