This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-1002. Submarine model management database and database sdk #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeff-901 help me review this PR. Thanks. |
jeff-901
reviewed
Aug 30, 2021
Comment on lines
57
to
79
| DROP TABLE IF EXISTS `metrics`; | ||
| CREATE TABLE `metrics` ( | ||
| `id` varchar(64) NOT NULL COMMENT 'Id of the Experiment', | ||
| `key` varchar(190) NOT NULL COMMENT 'Metric key: `String` (limit 190 characters). Part of *Primary Key* for ``metrics`` table.', | ||
| `value` float NOT NULL COMMENT 'Metric value: `Float`. Defined as *Non-null* in schema.', | ||
| `worker_index` varchar(32) NOT NULL COMMENT 'Metric worker_index: `String` (limit 32 characters). Part of *Primary Key* for\r\n ``metrics`` table.', | ||
| `timestamp` bigint(20) NOT NULL COMMENT 'Timestamp recorded for this metric entry: `BigInteger`. Part of *Primary Key* for ``metrics`` table.', | ||
| `step` bigint(11) NOT NULL COMMENT 'Step recorded for this metric entry: `BigInteger`.', | ||
| `is_nan` BOOLEAN NOT NULL COMMENT 'True if the value is in fact NaN.', | ||
| PRIMARY KEY (`id`, `key`, `timestamp`, `worker_index`) | ||
| ) ENGINE=InnoDB DEFAULT CHARSET=utf8; | ||
|
|
||
| DROP TABLE IF EXISTS `params`; | ||
| CREATE TABLE `params` ( | ||
| `id` varchar(64) NOT NULL COMMENT 'Id of the Experiment', | ||
| `key` varchar(190) NOT NULL COMMENT '`String` (limit 190 characters). Part of *Primary Key* for ``params`` table.', | ||
| `value` varchar(32) NOT NULL COMMENT '`String` (limit 190 characters). Defined as *Non-null* in schema.', | ||
| `worker_index` varchar(32) NOT NULL COMMENT '`String` (limit 32 characters). Part of *Primary Key* for\r\n ``metrics`` table.', | ||
| PRIMARY KEY (`id`, `key`, `worker_index`) | ||
| ) ENGINE=InnoDB DEFAULT CHARSET=utf8; |
There was a problem hiding this comment.
Do metrics and params id need to be foreign key.
There was a problem hiding this comment.
It sounds great to add the foreign key constraint. I will add it. Thanks
KUAN-HSUN-LI
force-pushed
the
SUBMARINE-1002
branch
2 times, most recently
from
2490be6
to
2c1febe
Compare
|
@jeff-901 I have added the foreign key to both metrics and params. Help me review the following code, thanks. |
lowc1012
reviewed
Sep 4, 2021
KUAN-HSUN-LI
force-pushed
the
SUBMARINE-1002
branch
2 times, most recently
from
4dae603
to
d84b7da
Compare
KUAN-HSUN-LI
force-pushed
the
SUBMARINE-1002
branch
from
d84b7da
to
ec55144
Compare
pingsutw
approved these changes
Sep 12, 2021
There was a problem hiding this comment.
@KUAN-HSUN-LI, Thanks.
LGTM. will merge it if more comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
registered_models,registered_model_tags,model_versionsandmodel_version_tagstables.paramsandmetricstables fromsubmarine.sqltosubmarine-model.sqlWhat type of PR is it?
[Feature]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1002
How should this be tested?
run the sdk unit tests
pytest --cov=submarine -vs -m "not e2e"TestModelVersion and TestRegisteredModel are two relevant unit tests
Screenshots (if appropriate)
Questions: