This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-1025. Use minio client in init container to create bucket #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KUAN-HSUN-LI @pingsutw Please helm me review the code, thanks. |
|
The init container will always restart until minio pod is running. If minio pod fails, both submarine and mlflow pods will still restart the init container. Is this a serious problem? @pingsutw |
jeff-901
force-pushed
the
SUBMARINE-1025
branch
from
57fdeb6
to
46ea9ab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Migrate the minio logic to init container for submarine and mlflow pod. If the init container fails, let it restart.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1025
How should this be tested?
Original e2e test.
Screenshots (if appropriate)
Questions: