SUBMARINE-1021. Experiment Watcher #767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingsutw
reviewed
Oct 9, 2021
| LOG.error("Experiment watch failed. " + e.getMessage(), e); | ||
| } | ||
|
|
||
| // client.setDebugging(true); |
There was a problem hiding this comment.
I commented this line is because Watch in Java k8s client library seems not to support debugging mode, it made the watcher failed.
I'll just remove it.
| @@ -565,6 +584,79 @@ public ServeResponse deleteServe(ServeRequest spec) | |||
| } | |||
| } | |||
|
|
|||
| public void watchExperiment() throws ApiException{ | |||
There was a problem hiding this comment.
Could we add a unit test or integration test for it?
There was a problem hiding this comment.
After discussing in the meeting at Thursday, we think this function is hard to test because of its nature and it should be tested with the websocket developed following this PR. Maybe it is not too late to write a test for it at that time.
noidname01
force-pushed
the
SUBMARINE-1021
branch
from
73e9e5b
to
6571cbe
Compare
pingsutw
reviewed
Oct 15, 2021
| @@ -565,6 +584,79 @@ public ServeResponse deleteServe(ServeRequest spec) | |||
| } | |||
| } | |||
|
|
|||
| public void watchExperiment() throws ApiException{ | |||
| } | ||
| } finally { | ||
| LOG.info("WATCH PytorchJob END"); | ||
| throw new RuntimeException(); |
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException(); | |
| watchPytorch.close(); | |
| throw new RuntimeException(); |
| } | ||
| } finally { | ||
| LOG.info("WATCH TFJob END"); | ||
| throw new RuntimeException(); |
There was a problem hiding this comment.
Suggested change
| throw new RuntimeException(); | |
| watchTF.close(); | |
| throw new RuntimeException(); |
noidname01
force-pushed
the
SUBMARINE-1021
branch
from
6571cbe
to
9daa4af
Compare
pingsutw
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Use k8s java client to build watchers of TFJobs and PytorchJobs, logging status when the experiment status change.
Watcher examples
We will create a websocket connection between server and workbench, and modify the frontend logic of workbench in the following PRs.
What type of PR is it?
[Feature]
Todos
None
What is the Jira issue?
https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1021
How should this be tested?
It will run with the initializing of k8s submitter, then keep watching the experiments.
You can see the log when status of experiment changing.
Screenshots (if appropriate)
2021-10-06.21.46.52.mp4
Questions: