Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1045. Add static type parameter in submarine-sdk #775

Closed
wants to merge 17 commits into from
Closed

SUBMARINE-1045. Add static type parameter in submarine-sdk #775

wants to merge 17 commits into from

Conversation

rayray2002
Copy link
Contributor

@rayray2002 rayray2002 commented Oct 12, 2021 •
edited
Loading

What is this PR for?

Add fundamental static type parameter in submarine-sdk

What type of PR is it?

[Improvement]

Todos

Add module class type check like pytorch, tensorflow

What is the Jira issue?

https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1045

How should this be tested?

Mypy pass
Check if there are type error in run time

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

jeff-901
jeff-901 suggested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@jeff-901 jeff-901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add return type of functions.

submarine-sdk/pysubmarine/submarine/entities/model_registry/model_stages.py Outdated Show resolved Hide resolved
@xunliu
Copy link
Member

xunliu commented Oct 13, 2021

hi @rayray2002
Please change PR title to SUBMARINE-1045. Add static type parameter in submarine-sdk. Thanks.

@rayray2002 rayray2002 changed the title Submarine 1045. Add static type parameter in submarine-sdk SUBMARINE-1045. Add static type parameter in submarine-sdk Oct 13, 2021
pingsutw
pingsutw reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. We should not change those file which was generated by OpenAPI.
Those files have this header

    The version of the OpenAPI document: 0.7.0-SNAPSHOT
    Contact: dev@submarine.apache.org
    Generated by: https://openapi-generator.tech

submarine-sdk/pysubmarine/submarine/experiment/api_client.py Outdated Show resolved Hide resolved
submarine-sdk/pysubmarine/submarine/experiment/configuration.py Show resolved Hide resolved
@rayray2002 rayray2002 closed this Oct 19, 2021
@rayray2002 rayray2002 deleted the SUBMARINE-1045 branch October 19, 2021 05:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pingsutw pingsutw pingsutw left review comments

@jeff-901 jeff-901 jeff-901 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rayray2002 @xunliu @pingsutw @jeff-901