Skip to content
This repository has been archived by the owner on Jul 10, 2024. It is now read-only.

SUBMARINE-1196. Remove administrator docs on the submarine website #883

Closed
wants to merge 2 commits into from

Conversation

MortalHappiness
Copy link
Member

What is this PR for?

Currently, the administrator docs on the submarine website only contain Yarn-related docs. Therefore it can be removed.

What type of PR is it?

[Improvement]

Todos

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1196

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@pingsutw
Copy link
Member

Should remove Administrator Docs from sidebar.js.

"Administrator Docs": [
{
"Submarine on Yarn": ["adminDocs/yarn/README"],
},
],

@MortalHappiness
Copy link
Member Author

@pingsutw I found the build fail reason. I have already removed Administrator Docs from sidebar.js. The failed reason is that the following documentation references the adminDocs. Maybe this PR can be merged after those documentation re-written PRs are merged? Or should I push a new commit to remove those references in this PR?

For the meaning of the individual parameters, see the [QuickStart](../../adminDocs/yarn/README) page!

Check out the [Running Submarine on YARN](../../adminDocs/yarn/README)

@pingsutw
Copy link
Member

pingsutw commented Feb 20, 2022

oops, sorry. I didn't see that.
I think we can just remove Kaldi from the docs. we have those docs on the 0.6.0 website, so people still can find it in the future.

@pingsutw
Copy link
Member

pingsutw commented Feb 20, 2022

I think we could also remove the docs related to yarn under user docs.
https://github.com/apache/submarine/tree/master/website/versioned_docs/version-0.6.0/userDocs/yarn

@MortalHappiness
Copy link
Member Author

@pingsutw I have pushed a new commit. Thank you.

@asfgit asfgit closed this in 61851bc Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants