Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-1207. Move server-core/workbench/entity to server-api/workbench #902

Closed
wants to merge 5 commits into from

Conversation

raykuo18
Copy link
Contributor

What is this PR for?

Move files under submarine-server/server-core/src/main/java/org/apache/submarine/server/workbench/entity to submarine-server/server-api/src/main/java/org/apache/submarine/server/api/workbench.

What type of PR is it?

Refactoring

What is the Jira issue?

https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1207?filter=allopenissues

Screenshots (if appropriate)

No

Questions:

  • Do the license files need updating? /No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@MortalHappiness
Copy link
Member

The PR title should be SUBMARINE-1207 instead of Submarine 1207.

@raykuo18 raykuo18 changed the title Submarine 1207. Move server-core/workbench/entity to server-api/workbench Submarine-1207. Move server-core/workbench/entity to server-api/workbench Mar 21, 2022
@xunliu
Copy link
Member

xunliu commented Mar 22, 2022

hi @Ray02250418
Please change PR title to SUBMARINE-1207. Move ...

@raykuo18 raykuo18 changed the title Submarine-1207. Move server-core/workbench/entity to server-api/workbench SUBMARINE-1207. Move server-core/workbench/entity to server-api/workbench Mar 22, 2022
@raykuo18
Copy link
Contributor Author

@jeff-901 Please help me review the code.

Copy link
Contributor

@jeff-901 jeff-901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in 170c506 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants