This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-1285. Redesign the Security Implementation document #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
========================================
Coverage 9.18% 9.18%
Complexity 670 670
========================================
Files 234 234
Lines 23716 23716
Branches 3475 3475
========================================
Hits 2178 2178
Misses 21407 21407
Partials 131 131 Continue to review full report at Codecov.
|
cdmikechen
changed the title
cdmikechen
changed the title
4 tasks
pingsutw
approved these changes
Jul 18, 2022
asfgit
pushed a commit
that referenced
this pull request
Aug 9, 2022
### What is this PR for? Add simple type authentication for REST api. Use [pac4j](https://www.pac4j.org/index.html) for token generation and validation. Considering need to adapt to java8, this PR is using 4.5.6 instead of version pac4j 5 for the time being. ### What type of PR is it? Feature ### Todos * [x] - Add some configs for authentication * [x] - Add `SimpleFilter` * [x] - Modified some login api processing logic (no logout available yet) * [x] - Add test case ### What is the Jira issue? https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1294 ### How should this be tested? Have added a test case in `org.apache.submarine.server.security.SubmarineAuthSimpleTest` ### Screenshots (if appropriate) No ### Questions: * Do the license files need updating? No * Are there breaking changes for older versions? Yes * Does this need new documentation? Yes(link: #975) Author: cdmikechen <cdmikechen@hotmail.com> Signed-off-by: Kevin <pingsutw@apache.org> Closes #979 from cdmikechen/SUBMARINE-1294 and squashes the following commits: 2fff5bd [cdmikechen] add a test user b5d9b46 [cdmikechen] get config realtime 7c2b29f [cdmikechen] init provider 0105bac [cdmikechen] remove some test e0e0c25 [cdmikechen] change pc4j to 4.5.6 for adaptation of java8 909ffa9 [cdmikechen] Fist commit with pc4j 5.4.3 and test case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Complete Security Implementation document.
What type of PR is it?
Documentation
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1285
How should this be tested?
No
Screenshots (if appropriate)
No
Questions: