Merge pull request #13 from apache-superset/kristw--translator-lint

Fix lint issues in translation module

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-translation/package.json

@@ -15,7 +15,7 @@
     "build": "yarn run build:cjs && yarn run build:esm",
     "dev": "beemo babel --watch ./src --out-dir esm/ --esm",
     "jest": "beemo jest --color --coverage",
-    "eslint": "beemo eslint \"./{src,test}/**/*.{js,jsx,json,md}\"",
+    "eslint": "beemo eslint \"./{src,test}/**/*.{js,jsx,md}\"",
     "lint": "yarn run prettier && yarn run eslint",
     "lint:fix": "yarn run prettier --write && yarn run eslint --fix",
     "test": "yarn run jest",

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-translation/src/Translator.js

@@ -24,6 +24,7 @@ export default class Translator {
       return input;
     }
     const text = this.i18n.gettext(input);
-    return (args.length > 0) ? sprintf(text, ...args) : text;
+
+    return args.length > 0 ? sprintf(text, ...args) : text;
   }
 }

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-translation/src/TranslatorSingleton.js

@@ -4,13 +4,15 @@ let singleton;
 
 function configure(config) {
   singleton = new Translator(config);
+
   return singleton;
-};
+}
 
 function getInstance() {
   if (!singleton) {
     throw new Error('You must call configure(...) before calling other methods');
   }
+
   return singleton;
 }
 

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-translation/test/Translator.test.js

@@ -13,9 +13,11 @@ describe('Translator', () => {
       expect(new Translator({})).toBeInstanceOf(Translator);
     });
     it('initializes when config is specified', () => {
-      expect(new Translator({
-        languagePack: languagePackZh,
-      })).toBeInstanceOf(Translator);
+      expect(
+        new Translator({
+          languagePack: languagePackZh,
+        }),
+      ).toBeInstanceOf(Translator);
     });
   });
   describe('.translate(input, ...args)', () => {

superset-frontend/temporary_superset_ui/superset-ui/packages/superset-ui-translation/test/languagePacks/zh.json

@@ -11,4 +11,4 @@
       "Copy of %s": ["%s 的副本"]
     }
   }
-}
+}