chore: remove redundant adodbapi warning (#19557)

apache · Apr 7, 2022 · 0d331f5 · 0d331f5
1 parent d9343a4
commit 0d331f5
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/superset/db_engine_specs/__init__.py b/superset/db_engine_specs/__init__.py
@@ -116,6 +116,9 @@ def get_available_engine_specs() -> Dict[Type[BaseEngineSpec], Set[str]]:
                 hasattr(attribute, "dialect")
                 and inspect.isclass(attribute.dialect)
                 and issubclass(attribute.dialect, DefaultDialect)
+                # adodbapi dialect is removed in SQLA 1.4 and doesn't implement the
+                # `dbapi` method, hence needs to be ignored to avoid logging a warning
+                and attribute.dialect.driver != "adodbapi"
             ):
                 try:
                     attribute.dialect.dbapi()