Skip to content

Commit

Permalink
fix: Removetime_range_endpoints from query context object (#19423)
Browse files Browse the repository at this point in the history
* template for remove time_range_endpoints from query context

* Update superset/migrations/versions/2ed890b36b94_rm_time_range_endpoints_from_qc.py

Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>

* Update superset/migrations/versions/2ed890b36b94_rm_time_range_endpoints_from_qc.py

Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>

* fix reference

* fix column reference

* fix

* Update superset/migrations/versions/2ed890b36b94_rm_time_range_endpoints_from_qc.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
  • Loading branch information
3 people committed Mar 31, 2022
1 parent 8e29ec5 commit 129063d
Showing 1 changed file with 66 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""rm_time_range_endpoints_from_qc
Revision ID: 2ed890b36b94
Revises: 58df9d617f14
Create Date: 2022-03-29 18:03:48.977741
"""

# revision identifiers, used by Alembic.
revision = "2ed890b36b94"
down_revision = "58df9d617f14"

import json

import sqlalchemy as sa
from alembic import op
from sqlalchemy.dialects import postgresql
from sqlalchemy.ext.declarative import declarative_base

from superset import db

Base = declarative_base()


class Slice(Base):
__tablename__ = "slices"
id = sa.Column(sa.Integer, primary_key=True)
query_context = sa.Column(sa.Text)


def upgrade():
bind = op.get_bind()
session = db.Session(bind=bind)
for slc in session.query(Slice):
if slc.query_context:
try:
query_context = json.loads(slc.query_context)
except json.decoder.JSONDecodeError:
continue
queries = query_context.get("queries")
for query in queries:
query.get("extras", {}).pop("time_range_endpoints", None)
slc.queries = json.dumps(queries)

session.commit()
session.close()


def downgrade():
pass

0 comments on commit 129063d

Please sign in to comment.