-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(plugin-chart-table): sort and search time column (#669)
- Loading branch information
1 parent
18dfdd2
commit 142544c
Showing
5 changed files
with
88 additions
and
49 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
...mporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/utils/DateWithFormatter.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import { DataRecordValue } from '@superset-ui/chart'; | ||
| import { TimeFormatFunction } from '@superset-ui/time-format'; | ||
|
|
||
| const REGEXP_TIMESTAMP_NO_TIMEZONE = /T(\d{2}:){2}\d{2}$/; | ||
|
|
||
| /** | ||
| * Extended Date object with a custom formatter, and retains the original input | ||
| * when the formatter is simple `String(..)`. | ||
| */ | ||
| export default class DateWithFormatter extends Date { | ||
| formatter: TimeFormatFunction; | ||
|
|
||
| input: DataRecordValue; | ||
|
|
||
| constructor( | ||
| input: DataRecordValue, | ||
| { formatter = String, forceUTC = true }: { formatter?: TimeFormatFunction; forceUTC?: boolean }, | ||
| ) { | ||
| let value = input; | ||
| // assuming timestamps without a timezone is in UTC time | ||
| if (forceUTC && typeof value === 'string' && REGEXP_TIMESTAMP_NO_TIMEZONE.test(value)) { | ||
| value = `${value}Z`; | ||
| } | ||
|
|
||
| super(value as string); | ||
|
|
||
| this.input = input; | ||
| this.formatter = formatter; | ||
| } | ||
|
|
||
| toString(): string { | ||
| if (this.formatter === String) { | ||
| return String(this.input); | ||
| } | ||
| return this.formatter ? this.formatter(this) : Date.toString.call(this); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters