Skip to content

Commit

Permalink
fix(dashboard): Change text and icons in dashboard editmode (#21305)
Browse files Browse the repository at this point in the history
Co-authored-by: Herbert Gainor <herbert.gainor@preset.io>
Co-authored-by: geido <diegopucci.me@gmail.com>
  • Loading branch information
3 people committed Sep 30, 2022
1 parent 389fa31 commit 1d70079
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -243,17 +243,17 @@ describe('Dashboard edit', () => {
.click();

// add new markdown component
dragComponent('Markdown', 'new-component', false);
dragComponent('Text', 'new-component', false);

cy.get('[data-test="dashboard-markdown-editor"]')
cy.getBySel('dashboard-markdown-editor')
.should(
'have.text',
'✨Markdown✨Markdown✨MarkdownClick here to edit markdown',
'✨Header 1✨Header 2✨Header 3Click here to learn more about markdown formatting',
)
.click();
.click(10, 10);

cy.getBySel('dashboard-component-chart-holder').contains(
'Click here to edit [markdown](https://bit.ly/1dQOfRK)',
'Click here to learn more about [markdown formatting](https://bit.ly/1dQOfRK)',
);

cy.getBySel('dashboard-markdown-editor').click().type('Test resize');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,13 +69,13 @@ const propTypes = {

const defaultProps = {};

const MARKDOWN_PLACE_HOLDER = `# ✨Markdown
## ✨Markdown
### ✨Markdown
const MARKDOWN_PLACE_HOLDER = `# ✨Header 1
## ✨Header 2
### ✨Header 3
<br />
Click here to edit [markdown](https://bit.ly/1dQOfRK)`;
Click here to learn more about [markdown formatting](https://bit.ly/1dQOfRK)`;

const MARKDOWN_ERROR_MESSAGE = t('This markdown component has an error.');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ export default function DraggableNewDivider() {
<DraggableNewComponent
id={NEW_MARKDOWN_ID}
type={MARKDOWN_TYPE}
label="Markdown"
className="fa fa-code"
label="Text"
className="fa fa-font"
/>
);
}

0 comments on commit 1d70079

Please sign in to comment.