fix(dataset-api): allow undefined schema in post

apache · May 29, 2023 · 2373881 · 2373881
1 parent 50535e4
commit 2373881
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/superset/datasets/schemas.py b/superset/datasets/schemas.py
@@ -78,7 +78,7 @@ class DatasetMetricsPutSchema(Schema):
 
 class DatasetPostSchema(Schema):
     database = fields.Integer(required=True)
-    schema = fields.String(validate=Length(0, 250))
+    schema = fields.String(allow_none=True, validate=Length(0, 250))
     table_name = fields.String(required=True, allow_none=False, validate=Length(1, 250))
     sql = fields.String(allow_none=True)
     owners = fields.List(fields.Integer())
@@ -236,7 +236,9 @@ class GetOrCreateDatasetSchema(Schema):
         required=True, metadata={"description": "ID of database table belongs to"}
     )
     schema = fields.String(
-        metadata={"description": "The schema the table belongs to"}, allow_none=True
+        allow_none=True,
+        validate=Length(0, 250),
+        metadata={"description": "The schema the table belongs to"},
     )
     template_params = fields.String(
         metadata={"description": "Template params for the table"}

diff --git a/tests/integration_tests/datasets/api_tests.py b/tests/integration_tests/datasets/api_tests.py
@@ -530,7 +530,7 @@ def test_create_dataset_item(self):
         self.login(username="admin")
         table_data = {
             "database": main_db.id,
-            "schema": "",
+            "schema": None,
             "table_name": "ab_permission",
         }
         uri = "api/v1/dataset/"