Skip to content

Commit

Permalink
fix: Databricks views showing up as tables (#20674)
Browse files Browse the repository at this point in the history
  • Loading branch information
betodealmeida committed Jul 20, 2022
1 parent d90b973 commit 2c5201f
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion superset/db_engine_specs/databricks.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
# under the License.

from datetime import datetime
from typing import Any, Dict, Optional, TYPE_CHECKING
from typing import Any, Dict, List, Optional, TYPE_CHECKING

from sqlalchemy.engine.reflection import Inspector

from superset.constants import USER_AGENT
from superset.db_engine_specs.base import BaseEngineSpec
Expand Down Expand Up @@ -87,3 +89,16 @@ def get_extra_params(database: "Database") -> Dict[str, Any]:
}
extra.update(BaseEngineSpec.get_extra_params(database))
return extra

@classmethod
def get_table_names(
cls,
database: "Database",
inspector: Inspector,
schema: Optional[str],
) -> List[str]:
tables = set(super().get_table_names(database, inspector, schema))
views = set(cls.get_view_names(database, inspector, schema))
actual_tables = tables - views

return list(actual_tables)

0 comments on commit 2c5201f

Please sign in to comment.