-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
be9a396
commit 2e607e7
Showing
2 changed files
with
58 additions
and
51 deletions.
There are no files selected for viewing
55 changes: 55 additions & 0 deletions
55
superset-frontend/temporary_superset_ui/superset-ui/CONTRIBUTING.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
## Contributing guidelines | ||
|
||
### Setup local development | ||
|
||
1. clone this repo | ||
2. have `yarn` install package dependencies and manage the symlinking between packages for you | ||
|
||
```sh | ||
git clone ...superset-ui && cd superset-ui | ||
yarn install | ||
yarn build | ||
``` | ||
|
||
### File organization | ||
|
||
[lerna](https://github.com/lerna/lerna/) and [yarn](https://yarnpkg.com) are used to manage versions and dependencies between | ||
packages in this monorepo. | ||
|
||
``` | ||
superset-ui/ | ||
lerna.json | ||
package.json | ||
... | ||
packages/ | ||
package1/ | ||
package.json | ||
... | ||
src/ | ||
test/ # unit tests | ||
types/ # typescript type declarations | ||
... | ||
lib/ # commonjs output | ||
esm/ # es module output | ||
... | ||
... | ||
``` | ||
|
||
### Builds, linting, and testing | ||
|
||
Each package defines its own build config, linting, and testing. You can have lerna run commands | ||
across all packages using the syntax `yarn run test` (or `yarn run test:watch` for watch mode) from the root `@superset-ui` directory. | ||
|
||
* [Using Storybook](docs/storybook.md) - You can test your components independently from Superset app. | ||
* [Debugging Superset plugins in Superset app](docs/debugging.md) - Sometimes something went wrong and you have to do it. | ||
|
||
### Committing | ||
|
||
This repository follows [conventional commits](https://www.conventionalcommits.org/en/v1.0.0-beta.3/) guideline for commit messages and has a `commitlint` hook which will require you to have the valid commit message before committing. You can use `npm run commit` to help you create a commit message. | ||
|
||
### Publishing | ||
|
||
**Prerequisite:** You'll need an [npmjs.com](https://npmjs.com) account that is part of the `superset-ui` organization. | ||
|
||
1. Make sure you're logged in to NPM from your shell. Run `npm login` if necessary. | ||
2. To make the release, run `yarn run release` and follow the prompts. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters