Replace sliceFormData with the initial form data

apache · May 11, 2022 · 33690f9 · 33690f9
1 parent ed6e5f9
commit 33690f9
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx b/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx
@@ -252,6 +252,7 @@ function ExploreViewContainer(props) {
   const theme = useTheme();
 
   const isBeforeUnloadActive = useRef(false);
+  const initialFormData = useRef(props.form_data);
 
   const defaultSidebarsWidth = {
     controls_width: 320,
@@ -384,7 +385,7 @@ function ExploreViewContainer(props) {
 
   useEffect(() => {
     const formDataChanged = !isEmpty(
-      getFormDataDiffs(props.chart.sliceFormData, props.form_data),
+      getFormDataDiffs(initialFormData.current, props.form_data),
     );
     if (formDataChanged && !isBeforeUnloadActive.current) {
       window.addEventListener('beforeunload', handleUnloadEvent);
@@ -394,7 +395,7 @@ function ExploreViewContainer(props) {
       window.removeEventListener('beforeunload', handleUnloadEvent);
       isBeforeUnloadActive.current = false;
     }
-  }, [props.chart.sliceFormData, props.form_data]);
+  }, [props.form_data]);
 
   // cleanup beforeunload event listener
   // we use separate useEffect to call it only on component unmount instead of on every form data change