fix(dashboard): import handle missing excluded charts (#19088)

(cherry picked from commit 999c2c6)
apache · Apr 3, 2022 · 36561b7 · 36561b7
1 parent 2193e17
commit 36561b7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/superset/dashboards/commands/importers/v1/utils.py b/superset/dashboards/commands/importers/v1/utils.py
@@ -137,7 +137,7 @@ def update_id_refs(  # pylint: disable=too-many-locals
         scope_excluded = native_filter.get("scope", {}).get("excluded", [])
         if scope_excluded:
             native_filter["scope"]["excluded"] = [
-                id_map[old_id] for old_id in scope_excluded
+                id_map[old_id] for old_id in scope_excluded if old_id in id_map
             ]
 
     return fixed

diff --git a/tests/unit_tests/dashboards/commands/importers/v1/utils_test.py b/tests/unit_tests/dashboards/commands/importers/v1/utils_test.py
@@ -93,7 +93,7 @@ def test_update_native_filter_config_scope_excluded(app_context: None):
             },
         },
         "metadata": {
-            "native_filter_configuration": [{"scope": {"excluded": [101, 102]}}],
+            "native_filter_configuration": [{"scope": {"excluded": [101, 102, 103]}}],
         },
     }
     chart_ids = {"uuid1": 1, "uuid2": 2}