Skip to content

Commit

Permalink
feat: add possibility to set ingress class name in Helm chart (#17252)
Browse files Browse the repository at this point in the history
* add possibility to set ingress class name

* remove ingress class annotation comment

Co-authored-by: Piotr Kostrzeński <piotr.kostrzenski@samba.tv>
  • Loading branch information
Jolcik and Piotr Kostrzeński committed Oct 28, 2021
1 parent be6cca5 commit 37909aa
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion helm/superset/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ maintainers:
- name: craig-rueda
email: craig@craigrueda.com
url: https://github.com/craig-rueda
version: 0.3.11
version: 0.3.12
dependencies:
- name: postgresql
version: 10.2.0
Expand Down
3 changes: 3 additions & 0 deletions helm/superset/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ metadata:
{{ toYaml . | indent 4 }}
{{- end }}
spec:
{{- if .Values.ingress.ingressClassName }}
ingressClassName: {{ .Values.ingress.ingressClassName }}
{{- end }}
{{- if .Values.ingress.tls }}
tls:
{{- range .Values.ingress.tls }}
Expand Down
2 changes: 1 addition & 1 deletion helm/superset/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ service:

ingress:
enabled: false
# ingressClassName: nginx
annotations: {}
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
## Extend timeout to allow long running queries.
# nginx.ingress.kubernetes.io/proxy-connect-timeout: "300"
Expand Down

0 comments on commit 37909aa

Please sign in to comment.