-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add database and schema names to dataset option (#25569)
Co-authored-by: Sonia <sonia.gautam@agoda.com>
- Loading branch information
Showing
5 changed files
with
179 additions
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
136 changes: 136 additions & 0 deletions
136
superset-frontend/src/features/datasets/DatasetSelectLabel/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import React from 'react'; | ||
| import { Tooltip } from 'src/components/Tooltip'; | ||
| import { styled, t } from '@superset-ui/core'; | ||
|
|
||
| type Database = { | ||
| database_name: string; | ||
| }; | ||
|
|
||
| export type Dataset = { | ||
| id: number; | ||
| table_name: string; | ||
| datasource_type?: string; | ||
| schema: string; | ||
| database: Database; | ||
| }; | ||
|
|
||
| const TooltipContent = styled.div` | ||
| ${({ theme }) => ` | ||
| .tooltip-header { | ||
| font-size: ${theme.typography.sizes.m}px; | ||
| font-weight: ${theme.typography.weights.bold}; | ||
| } | ||
| .tooltip-description { | ||
| margin-top: ${theme.gridUnit * 2}px; | ||
| display: -webkit-box; | ||
| -webkit-line-clamp: 20; | ||
| -webkit-box-orient: vertical; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| } | ||
| `} | ||
| `; | ||
|
|
||
| const StyledLabelContainer = styled.div` | ||
| ${({ theme }) => ` | ||
| left: ${theme.gridUnit * 3}px; | ||
| right: ${theme.gridUnit * 3}px; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| display: block; | ||
| `} | ||
| `; | ||
|
|
||
| const StyledLabel = styled.span` | ||
| ${({ theme }) => ` | ||
| left: ${theme.gridUnit * 3}px; | ||
| right: ${theme.gridUnit * 3}px; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| display: block; | ||
| `} | ||
| `; | ||
|
|
||
| const StyledDetailWrapper = styled.div` | ||
| display: grid; | ||
| grid-template-columns: auto auto; | ||
| justify-content: start; | ||
| width: 100%; | ||
| `; | ||
|
|
||
| const StyledLabelDetail = styled.span` | ||
| ${({ | ||
| theme: { | ||
| typography: { sizes, weights }, | ||
| }, | ||
| }) => ` | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| font-size: ${sizes.s}px; | ||
| font-weight: ${weights.light}; | ||
| line-height: 1.6; | ||
| `} | ||
| `; | ||
|
|
||
| const isValidValue = (value: string): boolean => | ||
| !['null', 'none'].includes(value.toLowerCase()) && value.trim() !== ''; | ||
|
|
||
| export const DatasetSelectLabel = (item: Dataset) => ( | ||
| <Tooltip | ||
| mouseEnterDelay={0.2} | ||
| placement="right" | ||
| title={ | ||
| <TooltipContent> | ||
| <div className="tooltip-header"> | ||
| {item.table_name && isValidValue(item.table_name) | ||
| ? item.table_name | ||
| : t('Not defined')} | ||
| </div> | ||
| <div className="tooltip-description"> | ||
| <div> | ||
| {t('Database')}: {item.database.database_name} | ||
| </div> | ||
| <div> | ||
| {t('Schema')}:{' '} | ||
| {item.schema && isValidValue(item.schema) | ||
| ? item.schema | ||
| : t('Not defined')} | ||
| </div> | ||
| </div> | ||
| </TooltipContent> | ||
| } | ||
| > | ||
| <StyledLabelContainer> | ||
| <StyledLabel> | ||
| {item.table_name && isValidValue(item.table_name) | ||
| ? item.table_name | ||
| : item.database.database_name} | ||
| </StyledLabel> | ||
| <StyledDetailWrapper> | ||
| <StyledLabelDetail>{item.database.database_name}</StyledLabelDetail> | ||
| {item.schema && isValidValue(item.schema) && ( | ||
| <StyledLabelDetail> - {item.schema}</StyledLabelDetail> | ||
| )} | ||
| </StyledDetailWrapper> | ||
| </StyledLabelContainer> | ||
| </Tooltip> | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters