fix tests

apache · Jul 23, 2021 · 3ce834a · 3ce834a
1 parent 04f6396
commit 3ce834a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx b/superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
@@ -73,7 +73,7 @@ test('Rendering DataTablesPane correctly', () => {
   expect(screen.getByRole('img', { name: 'right' })).toBeVisible();
 });
 
-test('Shoud show tabs', async () => {
+test('Should show tabs', async () => {
   const props = createProps();
   render(<DataTablesPane {...props} />, { useRedux: true });
   expect(screen.queryByText('View results')).not.toBeInTheDocument();
@@ -83,7 +83,7 @@ test('Shoud show tabs', async () => {
   expect(screen.getByText('View samples')).toBeVisible();
 });
 
-test('Shoud show tabs: View results', async () => {
+test('Should show tabs: View results', async () => {
   const props = createProps();
   render(<DataTablesPane {...props} />, {
     useRedux: true,
@@ -93,7 +93,7 @@ test('Shoud show tabs: View results', async () => {
   expect(screen.getByText('0 rows retrieved')).toBeVisible();
 });
 
-test('Shoud show tabs: View samples', async () => {
+test('Should show tabs: View samples', async () => {
   const props = createProps();
   render(<DataTablesPane {...props} />, {
     useRedux: true,

diff --git a/superset-frontend/src/explore/components/DataTablesPane/index.tsx b/superset-frontend/src/explore/components/DataTablesPane/index.tsx
@@ -155,11 +155,10 @@ export const DataTablesPane = ({
       })
         .then(({ json }) => {
           // Only displaying the first query is currently supported
-          const result = ensureIsArray(json.result);
-          if (result.length > 1) {
+          if (json.result.length > 1) {
             const data: any[] = [];
-            result.forEach(item => {
-              ensureIsArray(item.data).forEach((row, i) => {
+            json.result.forEach((item: { data: any[] }) => {
+              item.data.forEach((row, i) => {
                 if (data[i] !== undefined) {
                   data[i] = { ...data[i], ...row };
                 } else {
@@ -174,7 +173,7 @@ export const DataTablesPane = ({
           } else {
             setData(prevData => ({
               ...prevData,
-              [resultType]: result[0].data,
+              [resultType]: json.result[0].data,
             }));
           }