Skip to content

Commit

Permalink
fix(explore-sqllab): make that Timestamp column keep the Is temporal …
Browse files Browse the repository at this point in the history
…flagged when overwriting (#19010)
  • Loading branch information
prosdev0107 committed Mar 25, 2022
1 parent e15573d commit 4463586
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion superset-frontend/src/SqlLab/components/ResultSet/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,10 @@ export default class ResultSet extends React.PureComponent<
dbId,
datasetToOverwrite.datasetId,
sql,
results.selected_columns.map(d => ({ column_name: d.name })),
results.selected_columns.map(d => ({
column_name: d.name,
is_dttm: d.is_date,
})),
datasetToOverwrite.owners.map((o: DatasetOwner) => o.id),
true,
);
Expand Down
1 change: 1 addition & 0 deletions superset-frontend/src/SqlLab/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { ToastType } from 'src/components/MessageToasts/types';

export type Column = {
name: string;
is_date?: boolean;
};

export type QueryState =
Expand Down

0 comments on commit 4463586

Please sign in to comment.