addressing feedback

apache · Dec 1, 2022 · 5730d3b · 5730d3b
1 parent 515ce47
commit 5730d3b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx b/superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx
@@ -132,7 +132,7 @@ export default function ErrorAlert({
       {description && (
         <div className="error-body">
           <p>{description}</p>
-          {!isExpandable && body && (
+          {!isExpandable && (
             <span
               role="button"
               tabIndex={0}
@@ -212,8 +212,12 @@ export default function ErrorAlert({
           }
         >
           <>
-            <p>{subtitle}</p>
-            <br />
+            {subtitle && (
+              <>
+                <p>{subtitle}</p>
+                <br />
+              </>
+            )}
             {body}
           </>
         </ErrorModal>

diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
@@ -1165,9 +1165,9 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
             description={t(
               'We are unable to connect to your database. Click "See more" for database-provided information that may help troubleshoot the issue.',
             )}
-            stackTrace={alertErrors?.[0] || validationErrors?.description}
-            subtitle={validationErrors?.description}
+            stackTrace={alertErrors?.[0]}
             copyText={validationErrors?.description}
+            subtitle={validationErrors?.description}
           />
         </ErrorAlertContainer>
       );