fix: explore warnings cleanup (#20864)

apache · Jul 26, 2022 · 5d107b8 · 5d107b8
1 parent 6b0c303
commit 5d107b8
Show file tree

Hide file tree

Showing 10 changed files with 7 additions and 84 deletions.
diff --git a/superset-frontend/plugins/plugin-chart-handlebars/src/consts.ts b/superset-frontend/plugins/plugin-chart-handlebars/src/consts.ts
@@ -18,10 +18,7 @@
  */
 import { debounce } from 'lodash';
 import { formatSelectOptions } from '@superset-ui/chart-controls';
-import { addLocaleData, SLOW_DEBOUNCE, t } from '@superset-ui/core';
-import i18n from './i18n';
-
-addLocaleData(i18n);
+import { SLOW_DEBOUNCE, t } from '@superset-ui/core';
 
 export const PAGE_SIZE_OPTIONS = formatSelectOptions<number>([
   [0, t('page_size.all')],

diff --git a/superset-frontend/plugins/plugin-chart-handlebars/src/i18n.ts b/superset-frontend/plugins/plugin-chart-handlebars/src/i18n.ts
diff --git a/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-handlebars/src/plugin/controlPanel.tsx
@@ -22,8 +22,7 @@ import {
   getStandardizedControls,
   sections,
 } from '@superset-ui/chart-controls';
-import { addLocaleData, t } from '@superset-ui/core';
-import i18n from '../i18n';
+import { t } from '@superset-ui/core';
 import { allColumnsControlSetItem } from './controls/columns';
 import { groupByControlSetItem } from './controls/groupBy';
 import { handlebarsTemplateControlSetItem } from './controls/handlebarTemplate';
@@ -48,8 +47,6 @@ import {
 import { queryModeControlSetItem } from './controls/queryMode';
 import { styleControlSetItem } from './controls/style';
 
-addLocaleData(i18n);
-
 const config: ControlPanelConfig = {
   controlPanelSections: [
     sections.legacyTimeseriesTime,

diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
@@ -19,7 +19,6 @@
  */
 import React from 'react';
 import {
-  addLocaleData,
   ChartDataResponseResult,
   ensureIsArray,
   FeatureFlag,
@@ -50,11 +49,8 @@ import {
   getStandardizedControls,
 } from '@superset-ui/chart-controls';
 
-import i18n from './i18n';
 import { PAGE_SIZE_OPTIONS } from './consts';
 
-addLocaleData(i18n);
-
 function getQueryMode(controls: ControlStateMapping): QueryMode {
   const mode = controls?.query_mode?.value;
   if (mode === QueryMode.aggregate || mode === QueryMode.raw) {

diff --git a/superset-frontend/src/components/PageHeaderWithActions/index.tsx b/superset-frontend/src/components/PageHeaderWithActions/index.tsx
@@ -92,7 +92,7 @@ const buttonsStyles = (theme: SupersetTheme) => css`
   & .fave-unfave-icon {
     padding: 0 ${theme.gridUnit}px;
 
-    &:first-child {
+    &:first-of-type {
       padding-left: 0;
     }
   }

diff --git a/superset-frontend/src/explore/components/ExploreChartPanel.jsx b/superset-frontend/src/explore/components/ExploreChartPanel.jsx
@@ -62,7 +62,7 @@ const propTypes = {
   vizType: PropTypes.string.isRequired,
   form_data: PropTypes.object,
   ownState: PropTypes.object,
-  standalone: PropTypes.number,
+  standalone: PropTypes.bool,
   force: PropTypes.bool,
   timeout: PropTypes.number,
   chartIsStale: PropTypes.bool,

diff --git a/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx b/superset-frontend/src/explore/components/ExploreViewContainer/index.jsx
@@ -74,7 +74,7 @@ const propTypes = {
   controls: PropTypes.object.isRequired,
   forcedHeight: PropTypes.string,
   form_data: PropTypes.object.isRequired,
-  standalone: PropTypes.number.isRequired,
+  standalone: PropTypes.bool.isRequired,
   force: PropTypes.bool,
   timeout: PropTypes.number,
   impressionId: PropTypes.string,

diff --git a/superset-frontend/src/explore/components/controls/SelectControl.jsx b/superset-frontend/src/explore/components/controls/SelectControl.jsx
@@ -176,7 +176,6 @@ export default class SelectControl extends React.PureComponent {
       name,
       placeholder,
       onFocus,
-      optionRenderer,
       showHeader,
       value,
       tokenSeparators,
@@ -241,7 +240,6 @@ export default class SelectControl extends React.PureComponent {
       name: `select-${name}`,
       onChange: this.onChange,
       onFocus,
-      optionRenderer,
       options: this.state.options,
       placeholder,
       sortComparator: this.props.sortComparator,

diff --git a/superset-frontend/src/views/components/Menu.tsx b/superset-frontend/src/views/components/Menu.tsx
@@ -155,7 +155,7 @@ const StyledHeader = styled.header`
         .ant-menu > .ant-menu-item > a {
           padding: 0px;
         }
-        .main-nav .ant-menu-submenu-title > svg:nth-child(1) {
+        .main-nav .ant-menu-submenu-title > svg:nth-of-type(1) {
           display: none;
         }
         .ant-menu-item-active > a {

diff --git a/superset-frontend/src/views/menu.tsx b/superset-frontend/src/views/menu.tsx
@@ -31,7 +31,7 @@ import { Provider } from 'react-redux';
 import { setupStore } from './store';
 
 // Disable connecting to redux debugger so that the React app injected
-// Below the menu like SqlLab or Explore can conect its redux store to the debugger
+// Below the menu like SqlLab or Explore can connect its redux store to the debugger
 const store = setupStore(true);
 const container = document.getElementById('app');
 const bootstrapJson = container?.getAttribute('data-bootstrap') ?? '{}';