feat(plugin-chart-table): table x-filtering supports single select (#…

…1220) * fix(plugin-chart-echarts): table support single select * fix: remove comments
apache · Nov 26, 2021 · 631c867 · 631c867
1 parent 5614683
commit 631c867
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/...-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/TableChart.tsx b/...-frontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/TableChart.tsx
@@ -234,11 +234,13 @@ export default function TableChart<D extends DataRecord = DataRecord>(
 
   const toggleFilter = useCallback(
     function toggleFilter(key: string, val: DataRecordValue) {
-      const updatedFilters = { ...(filters || {}) };
+      let updatedFilters = { ...(filters || {}) };
       if (filters && isActiveFilterValue(key, val)) {
-        updatedFilters[key] = filters[key].filter((x: DataRecordValue) => x !== val);
+        updatedFilters = {};
       } else {
-        updatedFilters[key] = [...(filters?.[key] || []), val];
+        updatedFilters = {
+          [key]: [val],
+        };
       }
       if (Array.isArray(updatedFilters[key]) && updatedFilters[key].length === 0) {
         delete updatedFilters[key];