[explore] fix IN filter on numeric field (#2908)

apache · Jun 6, 2017 · 65f25a1 · 65f25a1
1 parent e0dd5d9
commit 65f25a1
Showing 1 changed file with 17 additions and 16 deletions.
diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
@@ -477,22 +477,23 @@ def get_sqla_query(  # sqla
                     if op == 'not in':
                         cond = ~cond
                     where_clause_and.append(cond)
-                if col_obj.is_num:
-                    eq = utils.string_to_num(flt['val'])
-                if op == '==':
-                    where_clause_and.append(col_obj.sqla_col == eq)
-                elif op == '!=':
-                    where_clause_and.append(col_obj.sqla_col != eq)
-                elif op == '>':
-                    where_clause_and.append(col_obj.sqla_col > eq)
-                elif op == '<':
-                    where_clause_and.append(col_obj.sqla_col < eq)
-                elif op == '>=':
-                    where_clause_and.append(col_obj.sqla_col >= eq)
-                elif op == '<=':
-                    where_clause_and.append(col_obj.sqla_col <= eq)
-                elif op == 'LIKE':
-                    where_clause_and.append(col_obj.sqla_col.like(eq))
+                else:
+                    if col_obj.is_num:
+                        eq = utils.string_to_num(flt['val'])
+                    if op == '==':
+                        where_clause_and.append(col_obj.sqla_col == eq)
+                    elif op == '!=':
+                        where_clause_and.append(col_obj.sqla_col != eq)
+                    elif op == '>':
+                        where_clause_and.append(col_obj.sqla_col > eq)
+                    elif op == '<':
+                        where_clause_and.append(col_obj.sqla_col < eq)
+                    elif op == '>=':
+                        where_clause_and.append(col_obj.sqla_col >= eq)
+                    elif op == '<=':
+                        where_clause_and.append(col_obj.sqla_col <= eq)
+                    elif op == 'LIKE':
+                        where_clause_and.append(col_obj.sqla_col.like(eq))
         if extras:
             where = extras.get('where')
             if where: