feat: add orderby shared control (#1122)

apache · Nov 26, 2021 · 6675e60 · 6675e60
1 parent 25318c3
commit 6675e60
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/...et_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx b/...et_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
@@ -113,7 +113,7 @@ export const dnd_adhoc_metric: SharedControlConfig<'DndMetricSelect'> = {
   default: (c: Control) => mainMetric(c.savedMetrics),
 };
 
-export const dnd_timeseries_limit_metric: SharedControlConfig<'DndMetricSelect'> = {
+export const dnd_sort_by: SharedControlConfig<'DndMetricSelect'> = {
   type: 'DndMetricSelect',
   label: t('Sort by'),
   default: null,

diff --git a/...superset_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/index.tsx b/...superset_ui/superset-ui/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
@@ -69,7 +69,7 @@ import {
   dnd_adhoc_filters,
   dnd_adhoc_metric,
   dnd_adhoc_metrics,
-  dnd_timeseries_limit_metric,
+  dnd_sort_by,
   dndColumnsControl,
   dndEntity,
   dndGroupByControl,
@@ -339,7 +339,7 @@ const limit: SharedControlConfig<'SelectControl'> = {
   ),
 };
 
-const timeseries_limit_metric: SharedControlConfig<'MetricsControl'> = {
+const sort_by: SharedControlConfig<'MetricsControl'> = {
   type: 'MetricsControl',
   label: t('Sort By'),
   default: null,
@@ -481,7 +481,8 @@ const sharedControls = {
   time_range,
   row_limit,
   limit,
-  timeseries_limit_metric: enableExploreDnd ? dnd_timeseries_limit_metric : timeseries_limit_metric,
+  timeseries_limit_metric: enableExploreDnd ? dnd_sort_by : sort_by,
+  orderby: enableExploreDnd ? dnd_sort_by : sort_by,
   series: enableExploreDnd ? dndSeries : series,
   entity: enableExploreDnd ? dndEntity : entity,
   x,