feat: bring lazy import back (#84)

apache · Nov 26, 2021 · 68ebb11 · 68ebb11
1 parent be7623e
commit 68ebb11
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/...-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/index.ts b/...-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/index.ts
@@ -19,12 +19,11 @@
 import { ChartPlugin } from '@superset-ui/chart';
 import createMetadata from './createMetadata';
 import transformProps from './transformProps';
-import Chart from './BoxPlot';
 
 export default class BoxPlotChartPlugin extends ChartPlugin {
   constructor() {
     super({
-      Chart,
+      loadChart: () => import('./BoxPlot'),
       metadata: createMetadata(),
       transformProps,
     });

diff --git a/...gins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/legacy/index.ts b/...gins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/BoxPlot/legacy/index.ts
@@ -19,12 +19,11 @@
 import { ChartPlugin } from '@superset-ui/chart';
 import createMetadata from '../createMetadata';
 import transformProps from './transformProps';
-import Chart from '../BoxPlot';
 
 export default class BoxPlotChartPlugin extends ChartPlugin {
   constructor() {
     super({
-      Chart,
+      loadChart: () => import('../BoxPlot'),
       metadata: createMetadata(true),
       transformProps,
     });

diff --git a/...set-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts b/...set-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/index.ts
@@ -3,13 +3,12 @@ import transformProps from './transformProps';
 import createMetadata from './createMetadata';
 import buildQuery from './buildQuery';
 import ChartFormData from './ChartFormData';
-import Chart from './Line';
 
 export default class LineChartPlugin extends ChartPlugin<ChartFormData> {
   constructor() {
     super({
       buildQuery,
-      Chart,
+      loadChart: () => import('./Line'),
       metadata: createMetadata(),
       transformProps,
     });

diff --git a/...plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts b/...plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/legacy/index.ts
@@ -1,12 +1,11 @@
 import { ChartPlugin } from '@superset-ui/chart';
 import transformProps from './transformProps';
 import createMetadata from '../createMetadata';
-import Chart from '../Line';
 
 export default class LineChartPlugin extends ChartPlugin {
   constructor() {
     super({
-      Chart,
+      loadChart: () => import('../Line'),
       metadata: createMetadata(true),
       transformProps,
     });