Put back a default count * metric (#2091)

apache · Feb 2, 2017 · 6b2eb04 · 6b2eb04
1 parent 898d80b
commit 6b2eb04
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/superset/models.py b/superset/models.py
@@ -1320,15 +1320,8 @@ def query(  # sqla
             for s in columns:
                 select_exprs.append(cols[s].sqla_col)
             metrics_exprs = []
-        elif not is_timeseries:
-            # use all columns if none were specified
-            for col_obj in cols.values():
-                select_exprs.append(col_obj.sqla_col)
-                metrics_exprs = []
-            row_limit = row_limit or 100
 
         if granularity:
-
             @compiles(ColumnClause)
             def visit_column(element, compiler, **kw):
                 """Patch for sqlalchemy bug

diff --git a/superset/viz.py b/superset/viz.py
@@ -269,7 +269,7 @@ def query_obj(self):
         """Building a query object"""
         form_data = self.form_data
         groupby = form_data.get("groupby") or []
-        metrics = form_data.get("metrics") or []
+        metrics = form_data.get("metrics") or ['count']
         extra_filters = self.get_extra_filters()
         granularity = (
             form_data.get("granularity") or form_data.get("granularity_sqla")