feat(legacy-preset-chart-nvd3): add richtooltip in nvd3 bar chart (#1…

…7615) * feat(legacy-preset-chart-nvd3): add richtooltip in nvd3 bar chart * add richtooltip in nvd3 bar chart
apache · Dec 2, 2021 · 72f3215 · 72f3215
1 parent ce92fc1
commit 72f3215
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts
@@ -35,6 +35,7 @@ import {
   yAxisLabel,
   yAxisShowMinmax,
   yAxisBounds,
+  richTooltip,
 } from '../NVD3Controls';
 
 const config: ControlPanelConfig = {
@@ -81,6 +82,7 @@ const config: ControlPanelConfig = {
         ['color_scheme'],
         [showLegend],
         [showBarValue],
+        [richTooltip],
         [barStacked],
         [
           {

diff --git a/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js b/superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js
@@ -673,16 +673,20 @@ function nvd3Vis(element, props) {
       chart.color(d => d.color || colorFn(cleanColorInput(d[colorKey])));
     }
 
-    if (isVizTypes(['line', 'area']) && useRichTooltip) {
+    if (isVizTypes(['line', 'area', 'bar', 'dist_bar']) && useRichTooltip) {
       chart.useInteractiveGuideline(true);
-      if (vizType === 'line') {
+      if (vizType === 'line' || vizType === 'bar') {
         chart.interactiveLayer.tooltip.contentGenerator(d =>
           generateRichLineTooltipContent(
             d,
             smartDateVerboseFormatter,
             yAxisFormatter,
           ),
         );
+      } else if (vizType === 'dist_bar') {
+        chart.interactiveLayer.tooltip.contentGenerator(d =>
+          generateCompareTooltipContent(d, yAxisFormatter),
+        );
       } else {
         // area chart
         chart.interactiveLayer.tooltip.contentGenerator(d =>