Skip to content

Commit

Permalink
fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
zhaoyongjie committed Oct 22, 2021
1 parent 96d4fb8 commit 78fce8b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion superset/connectors/sqla/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -1303,7 +1303,7 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma

if (
db_engine_spec.allows_alias_in_select
and db_engine_spec.allows_hidden_orderby_calculated_column
and db_engine_spec.allows_hidden_cc_in_orderby
and col.name in [select_col.name for select_col in select_exprs]
):
col = literal_column(col.name)
Expand Down
2 changes: 1 addition & 1 deletion superset/db_engine_specs/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods
# if True, use alias of select column for `order by`
# the True is safely for most database
# But for backward compatibility, False by default
allows_hidden_orderby_calculated_column = False
allows_hidden_cc_in_orderby = False

force_column_alias_quotes = False
arraysize = 0
Expand Down
2 changes: 1 addition & 1 deletion superset/db_engine_specs/bigquery.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class BigQueryEngineSpec(BaseEngineSpec):
# same cursor, so we need to run all statements at once
run_multiple_statements_as_one = True

allows_hidden_orderby_calculated_column = True
allows_hidden_cc_in_orderby = True

"""
https://www.python.org/dev/peps/pep-0249/#arraysize
Expand Down

0 comments on commit 78fce8b

Please sign in to comment.