fix: nvd3 tooltip bolding/non-linebreak on ONLY header row (#291)

* fix: adds class to header row, now used in css * fix: legend-header is now tooltip-header * style: prettier
apache · Nov 26, 2021 · 7a9d72f · 7a9d72f
1 parent 6e731be
commit 7a9d72f
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/package.json b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/package.json
@@ -118,7 +118,14 @@
       }
     },
     "babel": {
-      "plugins": [["@babel/plugin-transform-runtime", { "corejs": 3 }]]
+      "plugins": [
+        [
+          "@babel/plugin-transform-runtime",
+          {
+            "corejs": 3
+          }
+        ]
+      ]
     },
     "jest": {
       "timers": "real",
@@ -153,7 +160,12 @@
           "rules": {
             "react/jsx-no-literals": "off",
             "prefer-exponentiation-operator": "off",
-            "@typescript-eslint/no-explicit-any": ["warn", { "fixToUnknown": false }]
+            "@typescript-eslint/no-explicit-any": [
+              "warn",
+              {
+                "fixToUnknown": false
+              }
+            ]
           }
         }
       ]

diff --git a/...plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.css b/...plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.css
@@ -140,11 +140,11 @@
 }
 
 /* START tooltip styles - these prevent long column names from overflowing the tooltip */
-.nvtooltip tbody tr:first-child td {
+.nvtooltip .tooltip-header {
   white-space: nowrap;
   font-weight: bold;
 }
-.nvtooltip tbody tr:not(:first-child) td:nth-child(2) {
+.nvtooltip tbody tr:not(.tooltip-header) td:nth-child(2) {
   word-break: break-word;
 }
 /* END tooltip styles */
diff --git a/...ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/utils.js b/...ui/plugins/superset-ui-plugins/packages/superset-ui-legacy-preset-chart-nvd3/src/utils.js
@@ -142,7 +142,7 @@ export function generateAreaChartTooltipContent(d, timeFormatter, valueFormatter
     "<table><thead><tr><td colspan='4'>" +
     `<strong class='x-value'>${timeFormatter(d.value)}</strong>` +
     '</td></tr></thead><tbody>' +
-    '<tr><td></td><td>Category</td><td>Value</td><td>% to total</td></tr>';
+    '<tr class="tooltip-header"><td></td><td>Category</td><td>Value</td><td>% to total</td></tr>';
   d.series.forEach(series => {
     const key = getFormattedKey(series.key, true);
     let trClass = '';