chore(tests): migrate mssql tests to pytest (#18251)

* move test * migrate to pytest
apache · Feb 2, 2022 · 7ad38d5 · 7ad38d5
1 parent 8c37654
commit 7ad38d5
Show file tree

Hide file tree

Showing 3 changed files with 344 additions and 316 deletions.
diff --git a/tests/integration_tests/db_engine_specs/mssql_tests.py b/tests/integration_tests/db_engine_specs/mssql_tests.py
diff --git a/tests/unit_tests/db_engine_specs/test_kusto.py b/tests/unit_tests/db_engine_specs/test_kusto.py
@@ -20,6 +20,8 @@
 import pytest
 from flask.ctx import AppContext
 
+from tests.unit_tests.fixtures.common import dttm
+
 
 @pytest.mark.parametrize(
     "sql,expected",
@@ -119,16 +121,14 @@ def test_kql_parse_sql(app_context: AppContext) -> None:
     ],
 )
 def test_kql_convert_dttm(
-    app_context: AppContext, target_type: str, expected_dttm: str
+    app_context: AppContext, target_type: str, expected_dttm: str, dttm: datetime,
 ) -> None:
     """
     Test that date objects are converted correctly.
     """
 
     from superset.db_engine_specs.kusto import KustoKqlEngineSpec
 
-    dttm = datetime.strptime("2019-01-02 03:04:05.678900", "%Y-%m-%d %H:%M:%S.%f")
-    print(dttm)
     assert expected_dttm == KustoKqlEngineSpec.convert_dttm(target_type, dttm)
 
 
@@ -142,14 +142,12 @@ def test_kql_convert_dttm(
     ],
 )
 def test_sql_convert_dttm(
-    app_context: AppContext, target_type: str, expected_dttm: str
+    app_context: AppContext, target_type: str, expected_dttm: str, dttm: datetime,
 ) -> None:
     """
     Test that date objects are converted correctly.
     """
 
     from superset.db_engine_specs.kusto import KustoSqlEngineSpec
 
-    dttm = datetime.strptime("2019-01-02 03:04:05.678900", "%Y-%m-%d %H:%M:%S.%f")
-    print(dttm)
     assert expected_dttm == KustoSqlEngineSpec.convert_dttm(target_type, dttm)